Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve /did/create API [DEV-3197] #388

Merged
merged 45 commits into from
Oct 16, 2023
Merged

feat: Improve /did/create API [DEV-3197] #388

merged 45 commits into from
Oct 16, 2023

Conversation

abdulla-ashurov
Copy link
Contributor

@abdulla-ashurov abdulla-ashurov commented Sep 21, 2023

  • Form-based method:
    • Rename from methodSpecificIdAlgo to identifierFormatType
    • Remove assertionMethod
    • Add service as form-based (default to blank to skip)
    • Add @context (VerificationMethod) as form-based one-of-many.
    • Add: key to specify an existing key, either by key ID or by key alias (optional).
    • Remove didDocument
  • JSON-based:
    • Under options top-level property: Add: key at the top level as optional, which can be used to specify an existing key ID or alias. Keep: verificationMethodType. Use in conjunction with key above, or generate new.
    • KeepdidDocument, but this will be a partial DID Document (skip the verificationMethod section since it will be generated based on two inputs above
    • Added integration tests for testing /did/create API.

@abdulla-ashurov abdulla-ashurov added the enhancement New feature or request label Sep 21, 2023
@abdulla-ashurov abdulla-ashurov self-assigned this Sep 21, 2023
@ankurdotb
Copy link
Contributor

Task linked: DEV-3197 Improve /did/create API

src/helpers/helpers.ts Outdated Show resolved Hide resolved
src/controllers/issuer.ts Outdated Show resolved Hide resolved
src/controllers/issuer.ts Outdated Show resolved Hide resolved
src/controllers/issuer.ts Outdated Show resolved Hide resolved
src/controllers/issuer.ts Outdated Show resolved Hide resolved
src/controllers/issuer.ts Outdated Show resolved Hide resolved
src/controllers/issuer.ts Outdated Show resolved Hide resolved
src/controllers/issuer.ts Show resolved Hide resolved
src/controllers/issuer.ts Outdated Show resolved Hide resolved
src/controllers/issuer.ts Show resolved Hide resolved
Eengineer1
Eengineer1 previously approved these changes Sep 28, 2023
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Approving + leaving validation, mutable declarations for future enhancements.

Thanks!

@abdulla-ashurov
Copy link
Contributor Author

Looks good.

Approving + leaving validation, mutable declarations for future enhancements.

Thanks!

Merged DEV-3198

src/controllers/issuer.ts Outdated Show resolved Hide resolved
src/helpers/helpers.ts Outdated Show resolved Hide resolved
tests/did/create.positive.spec.ts Show resolved Hide resolved
@lampkin-diet lampkin-diet merged commit 9791dc6 into develop Oct 16, 2023
16 checks passed
@lampkin-diet lampkin-diet deleted the DEV-3197 branch October 16, 2023 09:08
cheqd-bot bot pushed a commit that referenced this pull request Oct 16, 2023
## [2.10.0-develop.1](2.9.4-develop.3...2.10.0-develop.1) (2023-10-16)

### Features

* Improve /did/create API [DEV-3197] ([#388](#388)) ([9791dc6](9791dc6))
@cheqd-bot
Copy link

cheqd-bot bot commented Oct 16, 2023

🎉 This PR is included in version 2.10.0-develop.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

cheqd-bot bot pushed a commit that referenced this pull request Oct 24, 2023
## [2.10.0](2.9.3...2.10.0) (2023-10-24)

### Features

* Improve /did/create API [DEV-3197] ([#388](#388)) ([9791dc6](9791dc6))

### Bug Fixes

* Investigate frequent logouts on Credential Service [DEV-3251] ([#395](#395)) ([14693c3](14693c3))
@cheqd-bot
Copy link

cheqd-bot bot commented Oct 24, 2023

🎉 This PR is included in version 2.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cheqd-bot cheqd-bot bot added the released label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants